Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} #29995

Merged
merged 1 commit into from Mar 22, 2024
Merged

Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} #29995

merged 1 commit into from Mar 22, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 22, 2024

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 22, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 22, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 22, 2024
@6543
Copy link
Member

6543 commented Mar 22, 2024

Can we delete listall in the normal list struckt now?

@lunny
Copy link
Member Author

lunny commented Mar 22, 2024

Can we delete listall in the normal list struckt now?

I don't think so or it's not a easy task at least for this PR.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2024
@6543 6543 merged commit f8ab9da into go-gitea:main Mar 22, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 22, 2024
@lunny lunny deleted the lunny/list_all branch March 22, 2024 12:59
@6543 6543 modified the milestones: 1.23.0, 1.22.0 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @6543 @silverwind @GiteaBot