Migrate gt-hidden to tw-hidden
#30046
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/frontend
modifies/templates
| .ui.buttons .button.tw-hidden:first-child + .button { | ||
| border-left: 1px solid var(--color-light-border); | ||
| } | ||
|
|
||
| .ui.buttons .button:last-child, | ||
| .ui.buttons .button:nth-last-child(2):has(+ .button.gt-hidden) { | ||
| .ui.buttons .button:nth-last-child(2):has(+ .button.tw-hidden) { |
There was a problem hiding this comment.
Erm… something is strange here.
How can this have any effect ever?
After all, display:none should mean that borders won't be calculated, right?
So if I'm not mistaken, we can simply delete these selector parts.
There was a problem hiding this comment.
There was a problem hiding this comment.
last-child matches on hidden elements as well, so without this selector had added the border on the invisible button and the second-to-last item that needed it had it missing. Now with this it works perfectly.
I agree the CSS on button groups is a hack and needs to be rewritten, but first we should migrate the button module from fomantic into first-party code.
There was a problem hiding this comment.
For example, why you only added nth-last-child(2), but not nth-last-child(3) even nth-last-child(4)? Many buttons could be "hidden".
For such case, maybe JS should be used to avoid such CSS tricks. Or the CSS tricks need a totally different name for special cases (and should be tested explicitly)
There was a problem hiding this comment.
but first we should migrate the
buttonmodule from fomantic into first-party code.
Which page/code needs such trick? I guess only one or two places at most, it's not worth to make the "buttons" that complex.
There was a problem hiding this comment.
Blame view, it's the only place I remember having such a button group. Feel free to take a shot.
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
* origin/main: Remove fomantic table module (go-gitea#30047) Fix menu buttons in issues and release (go-gitea#30056) Fix git grep search limit, add test (go-gitea#30071) Fix button hover border (go-gitea#30048) Fix Add/Remove WIP on pull request title failure (go-gitea#29999) Fix misuse of `TxContext` (go-gitea#30061) Remove jQuery `.attr` from the reaction selector (go-gitea#30052) Remove jQuery `.attr` from the ComboMarkdownEditor (go-gitea#30051) Remove jQuery `.attr` from the label edit exclusive checkbox (go-gitea#30053) Remove jQuery `.attr` from the repository topic bar (go-gitea#30050) Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (go-gitea#29990) Migrate `gt-hidden` to `tw-hidden` (go-gitea#30046) Forbid jQuery `is` and fix issues (go-gitea#30016) Remove fomantic segment module (go-gitea#30042) Migrate margin and padding helpers to tailwind (go-gitea#30043)
We have to define this one in helpers.css because tailwind only generates a single class but certain things rely on this being double-class. Command ran: