Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error when loading more lines in diff view #30141

Closed
M393 opened this issue Mar 27, 2024 · 1 comment
Closed

JS error when loading more lines in diff view #30141

M393 opened this issue Mar 27, 2024 · 1 comment
Labels

Comments

@M393
Copy link

M393 commented Mar 27, 2024

Description

This error happens when clicking multiple times in a row on the load-more-lines button:

repo-code.js:195 Uncaught (in promise) DOMException: Failed to set the 'outerHTML' property on 'Element': This element has no parent node.
    at http://vmlinux03data:3000/assets/js/index.js?v=1.21.10:101:15689
    at Generator.next (<anonymous>)
    at u (http://vmlinux03data:3000/assets/js/index.js?v=1.21.10:101:12477)

Url path: /[org]/[project]/commit/[commit-hash]

Gitea Version

1.21.10

Can you reproduce the bug on the Gitea demo site?

No.
Looks like the button gets disabled while loading more text with 1.22, so could not reproduce it there.

Log Gist

No response

Screenshots

image

Git Version

2.20.1

Operating System

Debian 10

How are you running Gitea?

Downloaded gitea-1.21.10-linux-amd64 from release page

Database

MySQL/MariaDB

@M393 M393 added the type/bug label Mar 27, 2024
@yp05327
Copy link
Contributor

yp05327 commented Apr 9, 2024

Looks like the button gets disabled while loading more text with 1.22, so could not reproduce it there.

Yes, as this has been fixed in #29385 by using htmx instead of jQuery, plz wait the new release of v1.22.
I will close this issue, feel free to reopen if you have more questions.

@yp05327 yp05327 closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants