Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go generate and go vet on all packages (#30529) #30541

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #30529 by @silverwind

Fixes: #30512

I think this does mean those tools would run on a potential vendor directory, but I'm not sure we really support vendoring of dependencies anymore.

release has a vendor prerequisite so likely the source tarballs contain vendor files?

Fixes: go-gitea#30512

I think this does mean those tools would run on a potential `vendor`
directory, but I'm not sure we really support vendoring of dependencies
anymore.

`release` has a `vendor` prerequisite so likely the source tarballs
contain vendor files?
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code modifies/internal labels Apr 17, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 17, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2024
@GiteaBot GiteaBot requested review from delvh and lunny April 17, 2024 09:40
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 17, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2024
@silverwind silverwind merged commit 5c55851 into go-gitea:release/v1.22 Apr 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/internal size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants