Improve "Reference in new issue" modal #30547

silverwind · 2024-04-17T21:04:45Z

Fixes: #29994

Also some misc enhancements done to the form in the modal.

silverwind · 2024-04-17T21:09:52Z

Selection state also fixed:

wxiaoguang · 2024-04-18T01:45:54Z

web_src/css/base.css

+.ui.search.dropdown > .text {
+  white-space: nowrap;
+  overflow: hidden;
+  text-overflow: ellipsis;


Why only "search dropdown" has these styles, but all ".ui.dropdown .menu > .item" also have "text-overflow: ellipsis" ?

Not sure if that's the best selector but it was one of the matching ones in this case. The classname on it is certainly some kind of abuse ui search normal selection dropdown.

I removed the search class from the selector, but would not do any more change to this currently. Actually I'm not sure I understand the question.

OK, I think the problem is clear now. We can't "overflow: hidden" to any general "dropdown" selector.

Because even .ui.selection or .ui.search it might contain images like avatars.

The dropdown was not designed to work this way.

Ref: Broken avatar css on main page #30624

Fixes: go-gitea#29994 Also some misc enhancements done to the form in the modal. <img width="840" alt="Screenshot 2024-04-17 at 23 02 55" src="https://github.com/go-gitea/gitea/assets/115237/e71fba55-55cd-4e48-a497-6b1025c36a43">

@silverwind

Backport #30547 by @silverwind Fixes: #29994 Also some misc enhancements done to the form in the modal. <img width="840" alt="Screenshot 2024-04-17 at 23 02 55" src="https://github.com/go-gitea/gitea/assets/115237/e71fba55-55cd-4e48-a497-6b1025c36a43"> Co-authored-by: silverwind <me@silverwind.io>

* giteaofficial/main: [skip ci] Updated translations via Crowdin Mock queue backoff duration (go-gitea#30553) Improve "Reference in new issue" modal (go-gitea#30547) Add a few root files to lint-spell (go-gitea#30530) Refactor and fix archive link bug (go-gitea#30535) Fixup app.example.ini for task section, which is now queue.task (go-gitea#30555) Some following up changes for routes (go-gitea#30550) Add form field id generation, remove duplicated ids (go-gitea#30546) Fix border-radius on view, blame and code search (go-gitea#30545) Disable enter key for accepting code completion in Monaco (go-gitea#30548)

Follow #30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text. ![image](https://github.com/go-gitea/gitea/assets/2114189/f6ceaabd-bc89-4bf2-baa2-a6f0324c1962)

Follow go-gitea#30547 (comment) Fix go-gitea#30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text. ![image](https://github.com/go-gitea/gitea/assets/2114189/f6ceaabd-bc89-4bf2-baa2-a6f0324c1962)

@wxiaoguang

Backport #30628 by @wxiaoguang Follow #30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text. ![image](https://github.com/go-gitea/gitea/assets/2114189/f6ceaabd-bc89-4bf2-baa2-a6f0324c1962) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

Follow go-gitea/gitea#30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text. ![image](https://github.com/go-gitea/gitea/assets/2114189/f6ceaabd-bc89-4bf2-baa2-a6f0324c1962) (cherry picked from commit 1e4867730b261352d63098b85cf53ca05867c8c2) (cherry picked from commit 112df5a)

Follow go-gitea/gitea#30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text. ![image](https://github.com/go-gitea/gitea/assets/2114189/f6ceaabd-bc89-4bf2-baa2-a6f0324c1962) (cherry picked from commit 1e4867730b261352d63098b85cf53ca05867c8c2)

Follow go-gitea/gitea#30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text. ![image](https://github.com/go-gitea/gitea/assets/2114189/f6ceaabd-bc89-4bf2-baa2-a6f0324c1962) (cherry picked from commit 1e4867730b261352d63098b85cf53ca05867c8c2) (cherry picked from commit 112df5a)

wxiaoguang · 2024-05-03T10:33:40Z

-> Fix some UI problems (dropdown/container) #30849

Follow #30345 Follow #30547 `ellipsis` / `white-space` shouldn't be put on the general dropdown components.

Follow go-gitea#30345 Follow go-gitea#30547 `ellipsis` / `white-space` shouldn't be put on the general dropdown components.

Backport #30849 by wxiaoguang Follow #30345 Follow #30547 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

Improve "Reference in new issue" modal

4b1fd8a

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2024

pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2024

github-actions bot added the modifies/templates This PR modifies the template files label Apr 17, 2024

silverwind added backport/v1.22 This PR should be backported to Gitea 1.22 and removed modifies/templates This PR modifies the template files labels Apr 17, 2024

remove div

f6a4d07

pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024

github-actions bot added the modifies/templates This PR modifies the template files label Apr 17, 2024

delvh approved these changes Apr 17, 2024

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 17, 2024

jolheiser approved these changes Apr 17, 2024

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2024

fix selection state

40755ef

wxiaoguang reviewed Apr 18, 2024

View reviewed changes

silverwind added 2 commits April 18, 2024 20:56

Merge branch 'main' into refnew

634de81

change selector, remove normal class

752c673

silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024

silverwind enabled auto-merge (squash) April 18, 2024 19:10

silverwind merged commit dd8e6ae into go-gitea:main Apr 18, 2024
26 checks passed

GiteaBot added this to the 1.23.0 milestone Apr 18, 2024

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024

GiteaBot mentioned this pull request Apr 18, 2024

Improve "Reference in new issue" modal (#30547) #30574

Merged

GiteaBot added the backport/done All backports for this PR have been created label Apr 18, 2024

lunny mentioned this pull request Apr 21, 2024

Broken avatar css on main page #30624

Closed

wxiaoguang mentioned this pull request Apr 21, 2024

Fix dropdown text ellipsis #30628

Merged

silverwind deleted the refnew branch April 21, 2024 20:03

GiteaBot mentioned this pull request Apr 21, 2024

Fix dropdown text ellipsis (#30628) #30633

Merged

wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024

wxiaoguang mentioned this pull request May 3, 2024

Fix some UI problems (dropdown/container) #30849

Merged

wxiaoguang added a commit that referenced this pull request May 6, 2024

Fix some UI problems (dropdown/container) (#30849)

eda10cc

Follow #30345 Follow #30547 `ellipsis` / `white-space` shouldn't be put on the general dropdown components.

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 6, 2024

Fix some UI problems (dropdown/container) (go-gitea#30849)

08a9dc5

Follow go-gitea#30345 Follow go-gitea#30547 `ellipsis` / `white-space` shouldn't be put on the general dropdown components.

GiteaBot mentioned this pull request May 6, 2024

Fix some UI problems (dropdown/container) (#30849) #30871

Merged

wxiaoguang added a commit that referenced this pull request May 6, 2024

Fix some UI problems (dropdown/container) (#30849) (#30871)

b22d7fd

Backport #30849 by wxiaoguang Follow #30345 Follow #30547 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

go-gitea locked as resolved and limited conversation to collaborators Jul 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve "Reference in new issue" modal #30547

Improve "Reference in new issue" modal #30547

silverwind commented Apr 17, 2024

silverwind commented Apr 17, 2024

wxiaoguang Apr 18, 2024

silverwind Apr 18, 2024

silverwind Apr 18, 2024

wxiaoguang Apr 21, 2024 •

edited

Loading

wxiaoguang commented May 3, 2024

Improve "Reference in new issue" modal #30547

Improve "Reference in new issue" modal #30547

Conversation

silverwind commented Apr 17, 2024

silverwind commented Apr 17, 2024

wxiaoguang Apr 18, 2024

Choose a reason for hiding this comment

silverwind Apr 18, 2024

Choose a reason for hiding this comment

silverwind Apr 18, 2024

Choose a reason for hiding this comment

wxiaoguang Apr 21, 2024 • edited Loading

Choose a reason for hiding this comment

wxiaoguang commented May 3, 2024

wxiaoguang Apr 21, 2024 •

edited

Loading