Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some following up changes for routes #30550

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Some following up changes for routes #30550

merged 5 commits into from
Apr 18, 2024

Conversation

wxiaoguang
Copy link
Contributor

  1. Switch back to the old order for reqRepoAdmin, context.RepoRef()
  2. Add a routing function info for global NotFound

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 18, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 18, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2024
@wxiaoguang wxiaoguang mentioned this pull request Apr 18, 2024
Merged
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024
@lunny lunny enabled auto-merge (squash) April 18, 2024 08:04
@lunny lunny merged commit d1ba5f4 into go-gitea:main Apr 18, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 18, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024
@wxiaoguang wxiaoguang deleted the fix-routes branch April 18, 2024 09:57
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 19, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f3b81c7 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Mock queue backoff duration (go-gitea#30553)
  Improve "Reference in new issue" modal (go-gitea#30547)
  Add a few root files to lint-spell (go-gitea#30530)
  Refactor and fix archive link bug (go-gitea#30535)
  Fixup app.example.ini for task section, which is now queue.task (go-gitea#30555)
  Some following up changes for routes (go-gitea#30550)
  Add form field id generation, remove duplicated ids (go-gitea#30546)
  Fix border-radius on view, blame and code search (go-gitea#30545)
  Disable enter key for accepting code completion in Monaco (go-gitea#30548)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @lunny @delvh @GiteaBot