Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project description rendering for org #30587

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fix project description rendering for org #30587

merged 2 commits into from
Apr 19, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 19, 2024 •
edited
Loading

Fix #30263

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 19, 2024
@wxiaoguang wxiaoguang mentioned this pull request Apr 19, 2024
Closed
@lunny
Copy link
Member

lunny commented Apr 19, 2024

Should we support to render the whole markdown syntax here? Because other descriptions like repositories just support a part of them like links,quotes,emoji.

@wxiaoguang
Copy link
Contributor Author

Should we support to render the whole markdown syntax here? Because other descriptions like repositories just support a part of them like links,quotes,emoji.

Other code already does so

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2024
@silverwind silverwind enabled auto-merge (squash) April 19, 2024 07:54
@silverwind silverwind merged commit eb24d97 into go-gitea:main Apr 19, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 19, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2024
@wxiaoguang wxiaoguang deleted the fix-org-project-render branch April 19, 2024 09:59
@wxiaoguang wxiaoguang mentioned this pull request Apr 19, 2024
Merged
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 19, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5f81fe7 
* giteaofficial/main:
  Fix project description rendering for org (go-gitea#30587)
  Fix changelog (main) (go-gitea#30582)
  Avoid importing `modules/web/middleware` in `modules/session` (go-gitea#30584)
  Enable npm cache on `setup-node` action (go-gitea#30577)
silverwind pushed a commit that referenced this pull request Apr 19, 2024
@wxiaoguang
Fix project description rendering for org (#30587) (#30599)
667427b 
Backport #30587

Manually tested with 1.21:



![image](https://github.com/go-gitea/gitea/assets/2114189/fbe9a2c9-0563-4d69-bcdb-8e5e41f288a1)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

URL links not clickable in Description of organization's projects
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot