Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some UI problems (dropdown/container) #30849

Merged
merged 2 commits into from
May 6, 2024
Merged

Fix some UI problems (dropdown/container) #30849

merged 2 commits into from
May 6, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 3, 2024 •
edited

Follow #30345
Follow #30547

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 3, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 3, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label May 3, 2024
@wxiaoguang wxiaoguang marked this pull request as draft May 3, 2024 09:13
@wxiaoguang wxiaoguang force-pushed the fix-ui-regression branch 3 times, most recently from c2f5327 to 844ac96 Compare May 3, 2024 10:24
@wxiaoguang wxiaoguang marked this pull request as ready for review May 3, 2024 10:28
@wxiaoguang wxiaoguang changed the title Fix some UI problems Fix some UI problems (dropdown/container) May 3, 2024
@wxiaoguang wxiaoguang mentioned this pull request May 3, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 3, 2024
@wxiaoguang wxiaoguang added backport/v1.22 This PR should be backported to Gitea 1.22 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 4, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 6, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 6, 2024 06:46
@wxiaoguang wxiaoguang merged commit eda10cc into go-gitea:main May 6, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 6, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 6, 2024
@wxiaoguang @GiteaBot
Fix some UI problems (dropdown/container) (go-gitea#30849)
08a9dc5 
Follow go-gitea#30345
Follow go-gitea#30547

`ellipsis` / `white-space` shouldn't be put on the general dropdown components.
@GiteaBot GiteaBot mentioned this pull request May 6, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 6, 2024
@wxiaoguang wxiaoguang deleted the fix-ui-regression branch May 6, 2024 07:19
wxiaoguang added a commit that referenced this pull request May 6, 2024
@GiteaBot @wxiaoguang
Fix some UI problems (dropdown/container) (#30849) (#30871)
b22d7fd 
Backport #30849 by wxiaoguang

Follow #30345
Follow #30547

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 7, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
36f7bf4 
* giteaofficial/main:
  Make "sync branch" also sync object format and add tests (go-gitea#30878)
  Make sure git version&feature are always prepared (go-gitea#30877)
  Get repo list with OrderBy alpha should respect owner too (go-gitea#30784)
  Fix some UI problems (dropdown/container) (go-gitea#30849)
  Fix some UI problems (install/checkbox) (go-gitea#30854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@HEREYUA HEREYUA HEREYUA approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @lunny @HEREYUA @GiteaBot