Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some UI problems (install/checkbox) #30854

Merged
merged 2 commits into from
May 6, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 3, 2024

Fix the space between the box and label for checkboxes, and fix incorrect usages in "repo-issue.js"

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 3, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 3, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/js labels May 3, 2024
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented May 3, 2024

Review by ignoring spaces https://github.com/go-gitea/gitea/pull/30854/files?diff=split&w=1

I have tested the changes manually.

Old

image

New

The UI & checkbox space looks better

image

image

@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels May 3, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 4, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 6, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 6, 2024 06:06
@wxiaoguang wxiaoguang merged commit ce8b11a into go-gitea:main May 6, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 6, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 6, 2024
Fix the space between the box and label for checkboxes, and fix incorrect usages in "repo-issue.js"
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 6, 2024
@wxiaoguang wxiaoguang deleted the fix-checkbox branch May 6, 2024 06:39
wxiaoguang added a commit that referenced this pull request May 6, 2024
Backport #30854 by wxiaoguang

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 7, 2024
* giteaofficial/main:
  Make "sync branch" also sync object format and add tests (go-gitea#30878)
  Make sure git version&feature are always prepared (go-gitea#30877)
  Get repo list with OrderBy alpha should respect owner too (go-gitea#30784)
  Fix some UI problems (dropdown/container) (go-gitea#30849)
  Fix some UI problems (install/checkbox) (go-gitea#30854)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants