Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a more obvious approve button for MRs #31010

Open
hawicz opened this issue May 17, 2024 · 2 comments
Open

Add a more obvious approve button for MRs #31010

hawicz opened this issue May 17, 2024 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@hawicz
Copy link

hawicz commented May 17, 2024

Feature Description

It is currently quite difficult for people to figure out how to approve a MR. They need to know to first switch to the "Files changed" tab, then they need to pretend to start a review by clicking on the "Review" button, then realize that the comment is optional, and finally click the "Approve" button.
All of this is decidedly non-obvious to anyone that hasn't been shown it before, and difficult to remember even if you have.

Please add an Approve button on the initial conversation page of a MR.

Screenshots

No response

@hawicz hawicz added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 17, 2024
@silverwind
Copy link
Member

silverwind commented May 17, 2024

This UI closely mirrors what GitHub has and the primary color should indicate the primary action for a reviewer. The location is so that the reviewer is forced to look at code, which is generally a good practice I guess because no one should blindly approve PRs.

@hawicz
Copy link
Author

hawicz commented May 18, 2024

Yes, I definitely agree that blindly approving PRs is to be avoided.
However, many reviews don't happen on the "Files Changes" tab, with reviewers looking at commits individually on the "Commits" tab, or even in a clone. Even when changes are reviewed there, people note their comments on individual lines, resolve those conversations as each one is addressed, and then end up at a loss at to what to do next - they've just finished their review, so have no reason to click on a button that would seem to start a new review.

An example of what I’d hope to see is the approach that Gitlab uses, where it shows an “Approve” button on its overview page:
gitlab-approval-button-comparison

For Gitea, it would be nicer if it showed a similar button next to the “doesn't have enough approvals” message, perhaps like this (don't particularly care whether it's blue, or green, or whatever):
gitea-approve-button-mockup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants