Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore make test target #3139

Merged
merged 3 commits into from
Dec 11, 2017
Merged

Restore make test target #3139

merged 3 commits into from
Dec 11, 2017

Conversation

ethantkoenig
Copy link
Member

@lafriks
Copy link
Member

lafriks commented Dec 10, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 10, 2017
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Dec 10, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 10, 2017
@lunny
Copy link
Member

lunny commented Dec 11, 2017 •
edited

make build != go build, This is not correct.

@ethantkoenig
Copy link
Member Author

@lunny fixed

@lunny
Copy link
Member

lunny commented Dec 11, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2017
@codecov-io
Copy link

codecov-io commented Dec 11, 2017 •
edited

Codecov Report

Merging #3139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3139   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files         275      275           
  Lines       40030    40030           
=======================================
  Hits        13951    13951           
  Misses      24084    24084           
  Partials     1995     1995
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/ssh_key.go 31.92% <0%> (-0.74%) ⬇️
models/repo.go 41.54% <0%> (+0.18%) ⬆️
models/repo_indexer.go 51.94% <0%> (+0.97%) ⬆️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a7de2...fdeb112. Read the comment docs.

@lunny lunny merged commit c082c3b into go-gitea:master Dec 11, 2017
@ethantkoenig ethantkoenig deleted the makefile branch December 18, 2017 06:12
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ethantkoenig @lafriks @lunny @codecov-io @tboerger