Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cron.archive_cleanup in config cheat sheet #3215

Merged
merged 1 commit into from
Dec 17, 2017
Merged

Add cron.archive_cleanup in config cheat sheet #3215

merged 1 commit into from
Dec 17, 2017

Conversation

strk
Copy link
Member

@strk strk commented Dec 17, 2017

@codecov-io
Copy link

codecov-io commented Dec 17, 2017 •
edited
Loading

Codecov Report

Merging #3215 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3215      +/-   ##
=========================================
+ Coverage   34.88%   34.9%   +0.01%     
=========================================
  Files         277     277              
  Lines       39990   39990              
=========================================
+ Hits        13952   13958       +6     
+ Misses      24023   24012      -11     
- Partials     2015    2020       +5
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo.go 41.28% <0%> (-0.19%) ⬇️
models/repo_indexer.go 52.91% <0%> (+0.97%) ⬆️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️
modules/indexer/repo.go 67.82% <0%> (+6.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6abfa48...224475f. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 17, 2017
lafriks
lafriks requested changes Dec 17, 2017
View reviewed changes
docs/content/doc/advanced/config-cheat-sheet.en-us.md Outdated
### Cron - Cleanup old repository archives (`cron.archive_cleanup`)

- `RUN_AT_START`: Enable this to run cron tasks at start time.
- `SCHEDULE`: Cron syntax for scheduling update mirrors, e.g. `@every 1h`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be Cron syntax for scheduling repository archive cleanup...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. Fixed and squash-rebased against current master.

@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Dec 17, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 17, 2017
@strk strk force-pushed the cron-archive_cleanup-in-cheat_sheet branch from 8a64481 to 4b1c0ee Compare December 17, 2017 13:59
@lafriks
Copy link
Member

lafriks commented Dec 17, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 17, 2017
@sapk
Copy link
Member

sapk commented Dec 17, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2017
sapk
sapk reviewed Dec 17, 2017
View reviewed changes
custom/conf/app.ini.sample
@@ -493,7 +493,11 @@ SCHEDULE = @every 24h

; Clean up old repository archives
[cron.archive_cleanup]
; Whether to enable the job
ENABLED = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this will change default case that would be default false before ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it was true by default already. Defaults are not taken from this file but are in code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled is true by default: https://github.com/go-gitea/gitea/blob/master/modules/setting/setting.go#L425-L435

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the mislead I was thinking of default bool in go but I forget that we define default in settings.

@strk
Copy link
Member Author

strk commented Dec 17, 2017

drone failure is about a tcp timeout, and I cannot restart it. will squash-rebase to master and force-push, fingers crossed

@strk
Improve cron.archive_cleanup docs in cheat sheet and app.ini.sample
224475f 
Include defaults in cheat sheet, for that section
@strk strk force-pushed the cron-archive_cleanup-in-cheat_sheet branch from a05981f to 224475f Compare December 17, 2017 14:28
@lafriks lafriks merged commit 9a0e2a8 into go-gitea:master Dec 17, 2017
@strk strk deleted the cron-archive_cleanup-in-cheat_sheet branch December 18, 2017 20:04
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@strk @codecov-io @lafriks @sapk @tboerger