Support default private when creating or migrating repository #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
Codecov Report
@@ Coverage Diff @@
## master #3239 +/- ##
==========================================
- Coverage 34.97% 34.96% -0.01%
==========================================
Files 277 277
Lines 40004 40014 +10
==========================================
+ Hits 13990 13991 +1
- Misses 23977 23985 +8
- Partials 2037 2038 +1
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
routers/repo/repo.go
Outdated
| case setting.RepoCreatingPrivate: | ||
| return true | ||
| } | ||
| return false |
There was a problem hiding this comment.
nit: add explicit case for RepoCreatingPublic, and add a default case in case setting.Repository.DefaultPrivate is something unexpected (maybe we will add more cases in the future)?
custom/conf/app.ini.sample
Outdated
| @@ -16,6 +16,8 @@ SCRIPT_TYPE = bash | |||
| ANSI_CHARSET = | |||
| ; Force every new repository to be private | |||
| FORCE_PRIVATE = false | |||
| ; Default private when create a new repository, 0: last user repo visiblity, 1: private, 2: public | |||
There was a problem hiding this comment.
Would it be better to use named constants ("last", "private", "public") e.g. like we do for RUN_MODE?
lunny
force-pushed
the
lunny/default_repo_private
branch
from
4d025f5
to
018b52e
Compare
|
@ethantkoenig done. |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
|
@lunny please fmt format |
lunny
force-pushed
the
lunny/default_repo_private
branch
from
28c336f
to
58b6778
Compare
|
Thank you @lunny ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #3235