Run update-ca-certificates to enable self-signed certs #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * We are using self-signed ssl certificates for internal services, which results in failures when gitea tries to communicate through webhooks with these. We would like to enable gitea to be able to use these certificates without having to build custom docker images. How * We add the internal certificates to /usr/local/share/ca-certificates on the host * We read-only mount /usr/local/share/ca-certificates from the host to /usr/local/share/ca-certificates in the container * We do a update-ca-certificates in the alpine container before starting gitea This should have no consequence for users that do not have the need to handle self-signed certificates, as update-ca-certificates should be idempotent.
Codecov Report
@@ Coverage Diff @@
## master #3708 +/- ##
=======================================
Coverage 35.79% 35.79%
=======================================
Files 288 288
Lines 41578 41578
=======================================
Hits 14881 14881
Misses 24501 24501
Partials 2196 2196Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
lafriks
approved these changes
Mar 22, 2018
tboerger
added
lgtm/need 1
jonasfranz
approved these changes
Mar 23, 2018
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
How
This should have no consequence for users that do not have the need to handle self-signed certificates, as update-ca-certificates should be idempotent.