Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: import order. #3736

Merged
merged 1 commit into from
Mar 29, 2018
Merged

refactor: import order. #3736

merged 1 commit into from
Mar 29, 2018

Conversation

appleboy
Copy link
Member

code.gitea.io/sdk/gitea is an external package.

@codecov-io
Copy link

Codecov Report

Merging #3736 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3736      +/-   ##
==========================================
- Coverage   35.77%   35.76%   -0.01%     
==========================================
  Files         289      289              
  Lines       41604    41604              
==========================================
- Hits        14884    14881       -3     
- Misses      24524    24525       +1     
- Partials     2196     2198       +2
Impacted Files Coverage Δ
routers/api/v1/repo/key.go 20.49% <ø> (ø) ⬆️
routers/api/v1/repo/hook.go 0% <ø> (ø) ⬆️
routers/api/v1/repo/release.go 43.84% <ø> (ø) ⬆️
routers/api/v1/repo/release_attachment.go 0% <ø> (ø) ⬆️
routers/api/v1/repo/issue_tracked_time.go 0% <ø> (ø) ⬆️
routers/api/v1/repo/subscriber.go 0% <ø> (ø) ⬆️
routers/api/v1/repo/issue_label.go 29.88% <ø> (ø) ⬆️
routers/api/v1/repo/collaborators.go 0% <ø> (ø) ⬆️
routers/api/v1/repo/label.go 0% <ø> (ø) ⬆️
routers/api/v1/repo/branch.go 43.75% <ø> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8beef8...c780768. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2018
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 29, 2018
@lunny lunny added this to the 1.5.0 milestone Mar 29, 2018
@lunny
Copy link
Member

lunny commented Mar 29, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2018
@lunny lunny merged commit 1c5cbc3 into go-gitea:master Mar 29, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants