creating migration with ".git" suffix in repo name causes 500 error

[tycho]

• Gitea version (or commit ref): 1.4.0
• Git version: 2.17.0
• Operating system: Linux 4.16.2
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite

Description

Creating a migration repository mirror with the name "whatever.git" causes this error to show up in the log:

2018/04/15 08:01:16 [...routers/repo/repo.go:146 handleCreateError()] [E] MigratePost: name pattern is not allowed [pattern: *.git]

but it also causes an error 500 on the web page, which tells me exactly nothing about what happened.

Screenshots

I'm not going to just screenshot the error 500 page. 😉

[techknowlogick]

Are you able to replicate this on try.gitea.io?
What happens if you name the migration on your instance without the .git suffix (just trying to see if the repo itself causes issues, as I've run into this with some repos. And yes I do see your error where it specifically mentions the name of the repo, just being extra thorough)

[tycho]

Yes. If I remove the .git suffix it probably works fine, but a 500 error is obviously not the right user experience. It should probably also automatically drop the .git suffix (or have some JS-level evaluation for that field to notify the user).

[techknowlogick]

I agree.

Currently it'll show an error if the git repo doesn't exist, to keep user experience the same the suffix check could be done similarly.

Screenshot of what the error looks like (excuse the dark look I have a custom theme applied to my instance):

[lunny]

Cannot reproduce this on master when remote is exist. Closed now and please feel free to reopen it.