Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Owner Name to differentiate when merging #3807

Merged
merged 14 commits into from Feb 12, 2019
Merged

Add the Owner Name to differentiate when merging #3807

merged 14 commits into from Feb 12, 2019

Conversation

gdutyifei
Copy link
Contributor

@gdutyifei gdutyifei commented Apr 17, 2018 •
edited

add the Owner Name to differentiate when merging

appleboy
appleboy previously requested changes Apr 17, 2018
View reviewed changes
templates/repo/pulls/compare.tmpl Outdated Show resolved Hide resolved
@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2018
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 19, 2018
@lafriks lafriks added this to the 1.5.0 milestone Apr 19, 2018
@lafriks
Copy link
Member

lafriks commented May 6, 2018

@appleboy fixed

jonasfranz
jonasfranz previously requested changes May 26, 2018
View reviewed changes
routers/repo/pull.go Outdated Show resolved Hide resolved
routers/repo/pull.go Outdated Show resolved Hide resolved
@techknowlogick techknowlogick modified the milestones: 1.5.0, 1.6.0 May 27, 2018
@techknowlogick techknowlogick modified the milestones: 1.6.0, 1.7.0 Aug 28, 2018
@codecov-io
Copy link

codecov-io commented Nov 1, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@baffea1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3807   +/-   ##
=========================================
  Coverage          ?   38.73%           
=========================================
  Files             ?      339           
  Lines             ?    49015           
  Branches          ?        0           
=========================================
  Hits              ?    18984           
  Misses            ?    27284           
  Partials          ?     2747
Impacted Files Coverage Δ
routers/repo/pull.go 34.13% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baffea1...bc20d24. Read the comment docs.

@techknowlogick
Copy link
Member

@appleboy @JonasFranzDEV please review

@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018
@techknowlogick
Copy link
Member

@appleboy @jonasfranz please review

@techknowlogick
Copy link
Member

@appleboy @jonasfranz I am going to clear your reviews so it won't block other maintainers review.

@techknowlogick techknowlogick dismissed stale reviews from jonasfranz and appleboy February 12, 2019 03:31

opening up reviews to other maintainers

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 12, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 12, 2019
@lafriks lafriks merged commit 7884353 into go-gitea:master Feb 12, 2019
@lafriks lafriks changed the title add the Owner Name to differentiate when merging Add the Owner Name to differentiate when merging Feb 12, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

@appleboy appleboy appleboy left review comments

@jonasfranz jonasfranz jonasfranz left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gdutyifei @lafriks @codecov-io @techknowlogick @appleboy @jonasfranz @bkcsoft @GiteaBot