Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note about adding permisions to binary #3936

Merged
merged 3 commits into from
May 10, 2018
Merged

Note about adding permisions to binary #3936

merged 3 commits into from
May 10, 2018

Conversation

techknowlogick
Copy link
Member

in regards to binding to lower ports than 1024

@techknowlogick
Note about adding permisions to binary
2ade0e1 
in regards to binding to lower ports than 1024
@codecov-io
Copy link

codecov-io commented May 10, 2018 •
edited

Codecov Report

Merging #3936 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3936      +/-   ##
==========================================
+ Coverage   20.26%   20.27%   +0.01%     
==========================================
  Files         146      146              
  Lines       29316    29316              
==========================================
+ Hits         5942     5945       +3     
+ Misses      22472    22470       -2     
+ Partials      902      901       -1
Impacted Files Coverage Δ
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efdb09...c014540. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2018
@lunny lunny added the type/docs This PR mainly updates/creates documentation label May 10, 2018
@lunny lunny added this to the 1.5.0 milestone May 10, 2018
@lunny
Copy link
Member

lunny commented May 10, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 10, 2018
@daviian
Copy link
Member

daviian commented May 10, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2018
@lunny lunny merged commit af62ec5 into go-gitea:master May 10, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@techknowlogick @codecov-io @lunny @daviian @bkcsoft