Fix comments in config1 #3946
Merged
Fix comments in config1 #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some comments in app.ini.sample were very vague, didn't contain much information. Some of them have been fixed, but mistakes that need to be fixed by an expert still remain, see go-gitea#3928 Signed-off-by: Mikolaj Holysz <miki123211@gmail.com>
Add an additional comment to the top of the sample configuration file. It contains a link pointing to gitea's docs and the configcheat sheet, which contains some explanations about the parameters in the config. Signed-off-by: Mikolaj Holysz <miki123211@gmail.com>
lafriks
approved these changes
May 10, 2018
bkcsoft
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #3946 +/- ##
=======================================
Coverage 20.27% 20.27%
=======================================
Files 146 146
Lines 29316 29316
=======================================
Hits 5945 5945
Misses 22470 22470
Partials 901 901Continue to review full report at Codecov.
|
techknowlogick
approved these changes
May 10, 2018
bkcsoft
added
lgtm/done
appleboy
approved these changes
May 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some comments in the sample configuration file. THose are mostly simple mistakes and some comments that didn't really make much sense.
A link to the config cheat sheet was also added to help users find more documentation.