Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix attachment ENABLED #4064

Merged
merged 2 commits into from
May 28, 2018
Merged

fix attachment ENABLED #4064

merged 2 commits into from
May 28, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented May 28, 2018

Will fix #4061

@lunny lunny added this to the 1.5.0 milestone May 28, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 28, 2018
@lunny lunny force-pushed the lunny/fix_attachement_enabled branch from 0d97ab9 to 0489b1a Compare May 28, 2018 14:45
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #4064 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4064   +/-   ##
=======================================
  Coverage   19.96%   19.96%           
=======================================
  Files         153      153           
  Lines       30478    30478           
=======================================
  Hits         6086     6086           
  Misses      23479    23479           
  Partials      913      913

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd274ff...0489b1a. Read the comment docs.

@lunny lunny merged commit 5c95f7c into go-gitea:master May 28, 2018
@lunny lunny deleted the lunny/fix_attachement_enabled branch May 28, 2018 14:56
lunny added a commit to lunny/gitea that referenced this pull request May 28, 2018
@lunny
fix attachment ENABLED (go-gitea#4064)
9ef2b85 
* fix attachment ENABLED

* change wrong name on app.ini.sample
@lunny lunny mentioned this pull request May 28, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label May 28, 2018
lunny added a commit that referenced this pull request May 29, 2018
@lunny
fix attachment ENABLED (#4064) (#4066)
7673ca9 
* fix attachment ENABLED

* change wrong name on app.ini.sample
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Failed to disable attachments
5 participants
@lunny @codecov-io @techknowlogick @jonasfranz @bkcsoft