-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swagger errors #4220
Fix swagger errors #4220
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4220 +/- ##
==========================================
+ Coverage 19.96% 19.97% +<.01%
==========================================
Files 153 153
Lines 30501 30514 +13
==========================================
+ Hits 6091 6094 +3
- Misses 23496 23506 +10
Partials 914 914
Continue to review full report at Codecov.
|
… different var name)
This one could maybe be in 1.5 milestone since it is only comments editing and that it can help use/generate swagger client. If not it will need to be backport I think. |
LGTM |
Totally awesome @sapk! Thanks for the ping @bkcsoft! I'm leaving a conference right now, headed for the airport. Just pulled master so I can look while unplugged -- I was puzzling over the correct way to implement some of these fixes myself. This lets me get back to working on client side this week; will publish repos as I go. (/me is still in conference mode and can't remember if we already have a docs or other page for listing API clients...) |
* fixes a warning remaining from go-gitea#4010 and go-gitea#4220
Fix all the resting errors to have a valid swagger file.
They are still some warnings but nothing blocking.
Doing so I found that some request still misses son parameters for some POST/PUT/PATCH request. This means the a client generated from the swagger file will not work completely.
Fix #4088 by activating validation in drone
Should fix #4010.