Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4255 - missing close tags in U2F #4256

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Fix #4255 - missing close tags in U2F #4256

merged 2 commits into from
Jun 19, 2018

Conversation

francoism90
Copy link
Contributor

No description provided.

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Jun 15, 2018
@codecov-io
Copy link

codecov-io commented Jun 15, 2018 •
edited
Loading

Codecov Report

Merging #4256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4256   +/-   ##
=======================================
  Coverage   19.97%   19.97%           
=======================================
  Files         153      153           
  Lines       30523    30523           
=======================================
  Hits         6097     6097           
  Misses      23512    23512           
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69bfd81...1514ca7. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 15, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2018
@jonasfranz
Copy link
Member

Fixes #4255

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2018
@lafriks lafriks added this to the 1.5.0 milestone Jun 19, 2018
@lafriks lafriks merged commit 8c6b232 into go-gitea:master Jun 19, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@francoism90 @codecov-io @jonasfranz @lafriks @techknowlogick @bkcsoft