Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to update certs #4296

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Remove call to update certs #4296

merged 2 commits into from
Jun 21, 2018

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jun 21, 2018

fix #3865 and also recover try.gitea.io

replaces: #4293

@techknowlogick
Copy link
Member Author

ping @inful A read-only mount to /etc/ssl/certs/ca-certificates.crt will resolve the same issue you were facing.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2018
@techknowlogick techknowlogick added this to the 1.5.0 milestone Jun 21, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2018
@codecov-io
Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #4296 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4296   +/-   ##
=======================================
  Coverage   20.09%   20.09%           
=======================================
  Files         153      153           
  Lines       30696    30696           
=======================================
  Hits         6168     6168           
  Misses      23586    23586           
  Partials      942      942

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3ea42...f202086. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2018
@techknowlogick techknowlogick merged commit e2721b6 into go-gitea:master Jun 21, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-5 branch June 21, 2018 21:13
@tboerger
Copy link
Member

@inful that's a snippet from my Gitea docker-compose deployment:

  server:
    image: gitea/gitea:1.4.2
    restart: always
    networks:
      - traefik
      - gitea
    labels:
      - traefik.docker.network=traefik
      - traefik.port=3000
      - traefik.frontend.passHostHeader=true
      - traefik.frontend.rule=Host:${GITEA_DOMAINS}
    healthcheck:
      test: ["NONE"]
      interval: 30s
      timeout: 10s
      retries: 5
    volumes:
      - /etc/ssl/certs/ca-certificates.crt:/etc/ssl/certs/ca-certificates.crt:ro
      - git:/data/git
      - gitea:/data/gitea
      - ssh:/data/ssh
    ports:
      - ${GITEA_SSH_PORT}:22
    depends_on:
      - db

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitea unable to start
5 participants