Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding review comment in split view #5038

Merged
merged 1 commit into from Oct 9, 2018
Merged

Fix adding review comment in split view #5038

merged 1 commit into from Oct 9, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 7, 2018

Fixes #4745

There is still problem that reply to already added comments does not seem to work in split view, still don't know why..

@lafriks lafriks added this to the 1.6.0 milestone Oct 7, 2018
@codecov-io
Copy link

Codecov Report

Merging #5038 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5038      +/-   ##
=========================================
- Coverage   37.41%   37.4%   -0.02%     
=========================================
  Files         306     306              
  Lines       45374   45374              
=========================================
- Hits        16978   16973       -5     
- Misses      25944   25948       +4     
- Partials     2452    2453       +1
Impacted Files Coverage Δ
models/repo_indexer.go 50.84% <0%> (-1.28%) ⬇️
models/repo_list.go 61.76% <0%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df46c5...a4ab42f. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 7, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2018
lunny
lunny approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @lafriks said, this is partilly fixing #4745, But I think it could be resolved by another PR.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 9, 2018
@lunny lunny merged commit fb3954f into go-gitea:master Oct 9, 2018
@jonasfranz jonasfranz mentioned this pull request Oct 9, 2018
Closed
1 task
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Cannot comment in split diff view
5 participants
@lafriks @codecov-io @lunny @techknowlogick @bkcsoft