only chown directories during docker setup if necessary. Fix #4425 #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Braun <fabian-braun@mailbox.org>
Codecov Report
@@ Coverage Diff @@
## master #5064 +/- ##
=========================================
Coverage ? 37.52%
=========================================
Files ? 310
Lines ? 45935
Branches ? 0
=========================================
Hits ? 17236
Misses ? 26223
Partials ? 2476Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
techknowlogick
approved these changes
Oct 29, 2018
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
Oct 30, 2018
bkcsoft
added
lgtm/done
aswild
added a commit
to aswild/gitea
that referenced
this pull request
Nov 6, 2018
Resolve some easy conflicts, write my own version of PR go-gitea#5064 because `stat` is a lot cleaner than screen-scraping `ls`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #4425 .
Instead of blindly running
chownduring setup, we check that the directory is not already owned by the correct user. Currently the check is non-recursive for speed (only checks the ownership of top-level directory).