Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings refactoring #5070

Open
renothing opened this issue Oct 11, 2018 · 2 comments
Open

settings refactoring #5070

renothing opened this issue Oct 11, 2018 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Comments

@renothing
Copy link
Contributor

there are so many global options for gitea. and the variables grew up more and more. it's so boring for upgrading, user have to check every config variable before upgrade. maybe it's better to make a distinction. we can make two part:

  • 1: readonly: like database settings, ssh server settings, domains
  • 2: writeable: like smtp, security etc...

and only keep part 1 in config file or read from enviroments, write part2 into database with default values.
then we can keep the docker image clearly and upgrading safe than before.

What do you think?

@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Oct 11, 2018
@lafriks
Copy link
Member

lafriks commented Oct 14, 2018

I would like to see writeable settings moved to configurable storage (file, databse, etc)

@lunny
Copy link
Member

lunny commented May 9, 2023

I think we already start moving part of configurations to database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants