Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint to new URL #5079

Merged
merged 1 commit into from Oct 12, 2018
Merged

Fix golint to new URL #5079

merged 1 commit into from Oct 12, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 12, 2018

Will fix drone builds

@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Oct 12, 2018
@lafriks lafriks added this to the 1.6.0 milestone Oct 12, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #5079 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5079      +/-   ##
==========================================
- Coverage   37.42%   37.41%   -0.02%     
==========================================
  Files         306      306              
  Lines       45374    45374              
==========================================
- Hits        16983    16976       -7     
- Misses      25941    25946       +5     
- Partials     2450     2452       +2
Impacted Files Coverage Δ
models/repo_indexer.go 52.11% <0%> (-2.12%) ⬇️
models/repo_list.go 61.76% <0%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b2c8a...9f94a19. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 12, 2018
@techknowlogick
Copy link
Member

@lafriks I think the built in github review required check doesn't account for non-mergers

@lafriks
Copy link
Member Author

lafriks commented Oct 12, 2018 •
edited

Yeah, seems so... I stiil can merge tho as owner :D

Update: disabled github built in aproval check

@lafriks lafriks merged commit c42b366 into go-gitea:master Oct 12, 2018
@lafriks lafriks deleted the fix/golint branch October 12, 2018 20:01
@lunny
Copy link
Member

lunny commented Oct 13, 2018

@lafriks why disabled github built-in approvals check?

@techknowlogick
Copy link
Member

@lunny because it only works if the person has write access, so @adelowo's apprval didn't count.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lafriks @codecov-io @techknowlogick @lunny @adelowo @bkcsoft