Incorrect status is shown on commit detail

[filipnavara]

• Gitea version (or commit ref): dd62ca7
• Git version: 2.8
• Operating system: Windows
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (https://try.gitea.io/filipnavara/test/pulls/1/commits)
  • No
  • Not relevant
• Log gist:

Description

The commit status displayed on the Commits tab on Pull Request is correctly the status reported for the particular commit. When the commit detail is open though the status displayed is taken for the HEAD or master branch, not for the correct commit.

Screenshots

[ollien]

Hi,

I'm interested in taking a crack at fixing this. I know this sounds silly, but how are you enabling commit status to begin with? I've scoured for the answer and having a bit of trouble.

[filipnavara]

Gitea implements the same API for statuses as GitHub: https://developer.github.com/v3/repos/statuses/

I created the example above by manually calling the API endpoint through Fiddler. There's a Golong API binding for the statuses at https://github.com/go-gitea/go-sdk.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[filipnavara]

It is not stale issue, still a very real bug.

[filipnavara]

Looks like similar issue as #5649, a PR was submitted for that one.

[filipnavara]

Fixed via #5650