Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set heatmap color range configurable #5165

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Oct 24, 2018

Should fix #5164 by allowing the customization of the color range along theming

Suggestion to use with arc-green theme : ['#2d303b', '#80bb46']
image

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 24, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2018
@jonasfranz jonasfranz added the topic/ui Change the appearance of the Gitea UI label Oct 24, 2018
@jonasfranz jonasfranz added this to the 1.7.0 milestone Oct 24, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7e5eec4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5165   +/-   ##
=========================================
  Coverage          ?   37.49%           
=========================================
  Files             ?      309           
  Lines             ?    45786           
  Branches          ?        0           
=========================================
  Hits              ?    17166           
  Misses            ?    26158           
  Partials          ?     2462
Impacted Files Coverage Δ
modules/setting/setting.go 48.24% <ø> (ø)
modules/templates/helper.go 49.4% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5eec4...798f258. Read the comment docs.

@jonasfranz jonasfranz merged commit ffd5fb8 into go-gitea:master Oct 24, 2018
@sapk sapk deleted the custom-heatmap-color-range branch October 24, 2018 14:48
@filipnavara
Copy link
Contributor

Wouldn't it make more sense to have HEATMAP_COLOR_RANGE in the theme?

@sapk
Copy link
Member Author

sapk commented Oct 24, 2018

@filipnavara theme only load a custom CSS if not the default. I choose the most simple fix that also allow customisation if used with an others theme or custom template but maybe we could improve it by setting the default based on theme used.

@lunny
Copy link
Member

lunny commented Oct 25, 2018

I like @filipnavara 's idea.

@lafriks
Copy link
Member

lafriks commented Oct 25, 2018

But our themes has only css I think so that not really possible currently but I would also better see this added to themes somehow than in configuration

@gsantner
Copy link

gsantner commented Oct 27, 2018

Have also noticed a problem with scale, take a look at https://goblinrefuge.com/mediagoblin/u/gsantner/m/gitea-heatmap-issue/ . Thought fits here because people worked on heatmap are already in this issue :D.

screenshot_20181027-120928

@lunny
Copy link
Member

lunny commented Oct 27, 2018

@gsantner Please fire another issue to describe that. Or maybe your issue has been fired on #5191 ?

@gsantner
Copy link

Oh, right it's nr 3. there

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heatmap on arc-green theme looks out of place
9 participants