Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race on updatesize #5190

Merged
merged 2 commits into from Oct 26, 2018
Merged

Fix race on updatesize #5190

merged 2 commits into from Oct 26, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 26, 2018

partially fix #5189

@lunny lunny added the type/bug label Oct 26, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 26, 2018
@codecov-io
Copy link

Codecov Report

Merging #5190 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5190      +/-   ##
=========================================
+ Coverage   37.49%   37.5%   +<.01%     
=========================================
  Files         309     309              
  Lines       45790   45791       +1     
=========================================
+ Hits        17170   17174       +4     
+ Misses      26157   26156       -1     
+ Partials     2463    2461       -2
Impacted Files Coverage Δ
models/repo.go 43.5% <100%> (ø) ⬆️
models/status.go 70.68% <37.5%> (+0.16%) ⬆️
models/repo_indexer.go 52.11% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb5655...f431105. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 26, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 26, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 26, 2018
@lafriks lafriks merged commit e782247 into go-gitea:master Oct 26, 2018
@lunny lunny deleted the lunny/fix_race branch October 29, 2018 08:24
lunny added a commit to lunny/gitea that referenced this pull request Oct 29, 2018
@lunny
Fix race on updatesize (go-gitea#5190)
13dec89 
* fix race on updatesize

* fix more repoPath
@lunny lunny mentioned this pull request Oct 29, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Oct 29, 2018
lunny added a commit that referenced this pull request Oct 30, 2018
@lunny
Fix race on updatesize (#5190) (#5215)
4d66de6 
* fix race on updatesize

* fix more repoPath
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Data races found by the race detector
5 participants
@lunny @codecov-io @lafriks @sapk @bkcsoft