Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer base branch bug #5555

Merged
merged 3 commits into from Dec 17, 2018
Merged

Fix nil pointer base branch bug #5555

merged 3 commits into from Dec 17, 2018

Conversation

jonasfranz
Copy link
Member

No description provided.

@jonasfranz
Add base repo nil check
3ebc6cd 
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz jonasfranz added this to the 1.7.0 milestone Dec 17, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 17, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2018
@codecov-io
Copy link

codecov-io commented Dec 17, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@8730ee0). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5555   +/-   ##
=========================================
  Coverage          ?   37.53%           
=========================================
  Files             ?      320           
  Lines             ?    47152           
  Branches          ?        0           
=========================================
  Hits              ?    17699           
  Misses            ?    26909           
  Partials          ?     2544
Impacted Files Coverage Δ
models/pull.go 50.72% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8730ee0...b3600cd. Read the comment docs.

@techknowlogick techknowlogick merged commit e726e4b into go-gitea:master Dec 17, 2018
@lunny
Copy link
Member

lunny commented Dec 18, 2018

Should this be back port to v1.6?

@lafriks
Copy link
Member

lafriks commented Dec 19, 2018

Yes please backport to 1.6

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo approved these changes

@kolaente kolaente kolaente approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jonasfranz @codecov-io @lunny @lafriks @adelowo @kolaente @techknowlogick @bkcsoft