Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Code Execution #5569

Closed
1 task done
snyff opened this issue Dec 20, 2018 · 8 comments · Fixed by #5571
Closed
1 task done

Remote Code Execution #5569

snyff opened this issue Dec 20, 2018 · 8 comments · Fixed by #5571
Labels
topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!

Comments

@snyff
Copy link

snyff commented Dec 20, 2018

The vulnerability impacting Gogs also impacts gitea
gogs/gogs#5558

Description

By using upload file with a malicious filename, an attacker is able to become any users and then gain code execution using hooks.

Gogs already worked on the issue in their develop branch

Screenshots

Me logged in as user_id 1

screen shot 2018-12-20 at 1 25 13 pm

@ghost
Copy link

ghost commented Dec 20, 2018

Is this responsible disclosure?

@snyff
Copy link
Author

snyff commented Dec 20, 2018

@jhabdas, I didn't know that Gitea and Gogs were sharing the same code base until I learnt a bit more about the projects and the schism. Once I learnt about it, I thought I should give you guys a heads-up.

@lunny
Copy link
Member

lunny commented Dec 20, 2018

@snyff could you send some detail to security at gitea.io ?

@lunny lunny added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Dec 20, 2018
@snyff
Copy link
Author

snyff commented Dec 20, 2018

sent!

@techknowlogick
Copy link
Member

@snyff thanks for the report. You will be thanked officially in the release blog post, and we appreciate your report 😄

@snyff
Copy link
Author

snyff commented Dec 21, 2018

@techknowlogick: thanks for that! Can you thank "@PentesterLab" or "Louis from PentesterLab (pentesterlab.com)" for example instead of snyff.

@techknowlogick
Copy link
Member

@snyff sounds good. The blog post PR is here: https://github.com/go-gitea/blog/pull/82/files#diff-e0f59ce8bb7e55f0518fc0ecafac06d7 is that suitable, or would you prefer something else.

@snyff
Copy link
Author

snyff commented Dec 21, 2018

That's perfect!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants