Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate commits and changes on new pull request #5632

Open
vijfhoek opened this issue Jan 4, 2019 · 2 comments
Open

Paginate commits and changes on new pull request #5632

vijfhoek opened this issue Jan 4, 2019 · 2 comments
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@vijfhoek
Copy link
Contributor

vijfhoek commented Jan 4, 2019 •
edited

Currently, commits and changes on a new pull request are not paginated. I just opened a massive pull request with almost 300 commits, which took about half a minute to render in my browser.

Perhaps we should limit it to ~50 commits (or something) and add pagination to browse through the commits.

I understand it's a pretty rare event, but it'd be nice to have.
@vijfhoek vijfhoek changed the title Paginate commits on new pull request Paginate commits and changes on new pull request Jan 4, 2019
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/enhancement An improvement of existing functionality labels Jan 6, 2019
@SebastianGode
Copy link

@lunny Are there any news to that?

@tischrei
Copy link

We have also such issues, because we are using PRs with 300 comments+. Our page load takes 4-5 minutes which is way too long and takes 1 GB RAM and more. Could anyone have a look on this and maybe introduce some performance buff / pagination?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lunny @vijfhoek @tischrei @SebastianGode