Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize "readme.md" #5691

Merged
merged 5 commits into from
Jan 14, 2019
Merged

Prioritize "readme.md" #5691

merged 5 commits into from
Jan 14, 2019

Conversation

wewark
Copy link
Contributor

@wewark wewark commented Jan 10, 2019

Fixes #5678
Check all the files in the home dir:

  • If a file matches exactly "readme.md", prioritize it over the others,
  • Otherwise, choose any file that matches "readme.md" but not strictly

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 10, 2019
lunny
lunny requested changes Jan 11, 2019
View reviewed changes
routers/repo/view.go Outdated Show resolved Hide resolved
@bkcsoft bkcsoft added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 11, 2019
@codecov-io
Copy link

codecov-io commented Jan 12, 2019 •
edited
Loading

Codecov Report

Merging #5691 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5691      +/-   ##
==========================================
+ Coverage   37.76%   37.77%   +0.01%     
==========================================
  Files         325      325              
  Lines       47650    47661      +11     
==========================================
+ Hits        17994    18005      +11     
  Misses      27062    27062              
  Partials     2594     2594
Impacted Files Coverage Δ
routers/repo/view.go 47.3% <100%> (+1.29%) ⬆️
modules/markup/markup.go 69.35% <100%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6868378...bbc6687. Read the comment docs.

kolaente
kolaente suggested changes Jan 12, 2019
View reviewed changes
docker/usr/bin/entrypoint Outdated Show resolved Hide resolved
modules/markup/markup.go Show resolved Hide resolved
options/locale/locale_fr-FR.ini Outdated Show resolved Hide resolved
options/locale/locale_fr-FR.ini Outdated Show resolved Hide resolved
modules/markup/markup_test.go Show resolved Hide resolved
routers/repo/view.go Show resolved Hide resolved
@lunny lunny added this to the 1.8.0 milestone Jan 13, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 13, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2019
@techknowlogick techknowlogick merged commit bd75965 into go-gitea:master Jan 14, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@kolaente kolaente kolaente approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Repository previews the wrong README.
7 participants
@wewark @codecov-io @lunny @techknowlogick @kolaente @lafriks @bkcsoft