Disable auto-migrate in docker container

[techknowlogick]

Credit to @zeripath

Hopefully fixes #5688

ping @AragurDEV

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@7d65ddf). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5730   +/-   ##
=========================================
  Coverage          ?   37.76%           
=========================================
  Files             ?      327           
  Lines             ?    47803           
  Branches          ?        0           
=========================================
  Hits              ?    18052           
  Misses            ?    27160           
  Partials          ?     2591

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d65ddf...92c0fda. Read the comment docs.

[zeripath]

This doesn't match the line I suggested:

(cd /app/gitea; exec su-exec $USER /app/gitea/gitea migrate)

Your suggested working directory isn't correct.

The thing is we need try to replicate the exact environment that docker runs Gitea in so that relative paths in the conf file work. See https://github.com/go-gitea/gitea/blob/master/docker/etc/s6/gitea/run

[techknowlogick]

@zeripath updated path

[zeripath]

OK I think this is worth a try. It's a shame we can't really test it...

[Aragur]

After using this PR migration is still not working:

gitea     | 2019/01/16 09:05:56 [I] Migration: add theme to users
gitea     | 2019/01/16 09:05:56 [...gitea/cmd/migrate.go:47 runMigrate()] [E] Failed to initialize ORM engine: sync database struct error: Error 1265: Data truncated for column 'theme' at row 1

[zeripath]

I think we should just remove it rather than comment it out but in either case disabling this seems appropriate.

[pr4xx]

But what was this used for? As far as I understand this is used to auto migrate for things like docker and using image :latest.

[zeripath]

There was a misunderstanding about why a user provided app.ini was not working. I think the issue actually might have been that the app.ini was not readable by Gitea.

In any case this fix caused more problems than it should have