Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Manage Topics' will not close when text field is empty #5755

Closed
5 tasks
HeshamTB opened this issue Jan 17, 2019 · 4 comments
Closed
5 tasks

'Manage Topics' will not close when text field is empty #5755

HeshamTB opened this issue Jan 17, 2019 · 4 comments
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@HeshamTB
Copy link

  • Gitea version (or commit ref): 1.6.3 30560b0
  • Git version: 2.20.1
  • Operating system: Arch GNU/Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • [ X ] SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • [ X ] Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

A simple bug. When in 'Code' tab in repo view, the 'Manage Topics' function can not be closed when the text field is empty unless the page is refreshed.
...

Screenshots

giteabug

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jan 20, 2019
@stale
Copy link

stale bot commented Mar 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 21, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Mar 22, 2019
@HeshamTB HeshamTB changed the title 'Manage Topics' will no close when text field is empty 'Manage Topics' will not close when text field is empty Mar 8, 2020
@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jun 5, 2022

Cannot reproduce on try.gitea.io v 1.17.0+dev-664-g73382d213

@wxiaoguang
Copy link
Contributor

I also did a quick test, it seems that the empty input can be saved correctly by clicking "Done" button.

However, there are some UI/UX problems:

  1. Not a11y friendly (it's not an easy task because the a11y of dropdown is not supported by Fomantic UI ....)
  2. The input will only be hidden when the network request is done. If user's network is laggy or broken, then clicking "Done" will make users feel that nothing happens.

Maybe this issue can be closed and these problem desires new issues.

@wxiaoguang wxiaoguang removed the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jun 6, 2022
@wxiaoguang
Copy link
Contributor

Thank you for reminding this issue, it has been fixed by #23626

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

6 participants