Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add support for private repos to open issues or wiki #5833

Closed
wants to merge 3 commits into from
Closed

WIP: add support for private repos to open issues or wiki #5833

wants to merge 3 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 24, 2019 •
edited
Loading

This PR will fix #639.

  • update repo settings
  • update permission check
  • list repos who allow anonymous visit on explore

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 24, 2019
@lunny lunny mentioned this pull request Jan 24, 2019
Open
@lunny lunny force-pushed the lunny/private_repo_public_units branch from beea6d0 to 6e507bd Compare January 24, 2019 15:51
lafriks
lafriks reviewed Jan 24, 2019
View reviewed changes
models/repo_permission.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2019
@codecov-io
Copy link

codecov-io commented Jan 24, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f21ae12). Click here to learn what that means.
The diff coverage is 55.26%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5833   +/-   ##
=========================================
  Coverage          ?   38.67%           
=========================================
  Files             ?      330           
  Lines             ?    48591           
  Branches          ?        0           
=========================================
  Hits              ?    18794           
  Misses            ?    27074           
  Partials          ?     2723
Impacted Files Coverage Δ
models/repo_unit.go 61.4% <ø> (ø)
modules/auth/repo_form.go 39% <ø> (ø)
routers/repo/setting.go 10.31% <0%> (ø)
modules/context/repo.go 59.57% <100%> (ø)
models/repo_permission.go 66.47% <57.69%> (ø)
routers/repo/view.go 47.32% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21ae12...a113f80. Read the comment docs.

@lunny lunny force-pushed the lunny/private_repo_public_units branch from 4a8bbe5 to a113f80 Compare February 4, 2019 03:51
@lunny lunny mentioned this pull request Feb 4, 2019
Open
@lunny lunny changed the title WIP: add support for repo open issues or wiki WIP: add support for private repos to open issues or wiki Feb 4, 2019
@lunny lunny added this to the 1.8.0 milestone Feb 7, 2019
adelowo
adelowo reviewed Feb 7, 2019
View reviewed changes
models/repo_permission.go
if p.UnitsMode == nil {
return p.AccessMode >= AccessModeRead
}
return len(p.UnitsMode) > 0
}

// UnitAccessMode returns current user accessmode to the specify unit of the repository
// UnitAccessMode returns the unit's minial accessmode to be accessed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing minial is supposed to minimal ?

@lunny lunny modified the milestones: 1.8.0, 1.9.0 Feb 28, 2019
@ashimokawa ashimokawa mentioned this pull request Mar 12, 2019
Closed
@stale
Copy link

stale bot commented Apr 29, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 29, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Apr 30, 2019
@stale stale bot removed the issue/stale label Apr 30, 2019
@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 4, 2019
@lunny lunny removed this from the 1.10.0 milestone Aug 19, 2019
@everdha
Copy link

everdha commented Dec 4, 2019

Hi, is there news about this merge? I would really like to see #639 resolved. Is this planned soon?
Thank you :)

@lunny
Copy link
Member Author

lunny commented Dec 4, 2019

I may continue the work on this during v1.12.

@everdha
Copy link

everdha commented Dec 4, 2019

Thank you for the quick response :) When is v1.12. to come aprox? May means not sure, isn't it?

@lafriks lafriks added this to the 1.12.0 milestone Feb 3, 2020
@tongclement
Copy link

Any ETA for this? Many thanks

@lunny lunny modified the milestones: 1.12.0, 1.13.0 Apr 19, 2020
@lunny
Copy link
Member Author

lunny commented Apr 19, 2020

@FalconBFR Sorry, it's not ready for v1.12.

@brunoais
Copy link

@lunny Is being ready for v1.13 very likely or is it more of a possible but not that likely? (Just trying to organize myself)

@lunny lunny modified the milestones: 1.13.0, 1.14.0 Sep 1, 2020
@techknowlogick techknowlogick modified the milestones: 1.14.0, 1.x.x Jan 24, 2021
@coolguy1771
Copy link

Has there been any progress on this issue?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 19, 2022 •
edited
Loading

This feature would be very complex. For example: if a writer writes a private repo URL in the the repo's public Issue, it would leak something in future, GitHub can show the code referred in issue.

In my environment, I just split repositories into two, one for private code, one for public issue/wiki.

@jpk6789
Copy link

jpk6789 commented May 20, 2022

Is there any progress on this feature? It would be very useful for us because we then can drop our separate issue tracker system and thus reduce our effort.

@lunny lunny removed this from the 1.x.x milestone Jan 18, 2023
@lunny
Copy link
Member Author

lunny commented Feb 1, 2023

Closed as it's outdated.

@lunny lunny closed this Feb 1, 2023
@lunny lunny deleted the lunny/private_repo_public_units branch February 1, 2023 12:07
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@adelowo adelowo adelowo left review comments

Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public issue trackers and/or wikis for private repositories