Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 when accessing commits instead of commit with 7-digit hash #6078

Open
1 task done
Aragur opened this issue Feb 15, 2019 · 2 comments
Open
1 task done

404 when accessing commits instead of commit with 7-digit hash #6078

Aragur opened this issue Feb 15, 2019 · 2 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented

Comments

@Aragur
Copy link

Aragur commented Feb 15, 2019

Description

When you access a commit with it's 7 digit hash and you use the plural of commit (commits) Gitea will redirect you to/commits/branch/master/{hash} which will result in a 404.
Example working URL:
https://try.gitea.io/AragurDEV/Test1234/commit/d375de4
Example broken URL:
https://try.gitea.io/AragurDEV/Test1234/commits/d375de4

root@system: ~ $ curl --head https://try.gitea.io/AragurDEV/Test1234/commits/d375de4
HTTP/2 302 
content-type: text/html; charset=utf-8
date: Fri, 15 Feb 2019 00:24:48 GMT
location: /AragurDEV/Test1234/commits/branch/master/d375de4
set-cookie: lang=en-US; Path=/; Max-Age=2147483647
set-cookie: i_like_gitea=11fb8d1072e778c1; Path=/; HttpOnly
set-cookie: _csrf=dScV8YPxCkDN0tRkNJRUEfWPLi06MTU1MDE5MDI4ODk4NTkxNjc4OQ%3D%3D; Path=/; Expires=Sat, 16 Feb 2019 00:24:48 GMT; HttpOnly
x-frame-options: SAMEORIGIN

Side note: this is used in nearly every changelog generator :)

Expected behavior

Handle 'commits' as 'commit' and show the commit :)

@Aragur
Copy link
Author

Aragur commented Feb 15, 2019

Okay I was a bit wrong:
Github handles it by showing a all commits to the specified commit for example: https://github.com/go-gitea/gitea/commits/7ae5956

@stale
Copy link

stale bot commented Apr 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 16, 2019
@techknowlogick techknowlogick added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Apr 16, 2019
@stale stale bot removed the issue/stale label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented
Projects
None yet
Development

No branches or pull requests

2 participants