Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the version within makefile overwriteable #6080

Merged
merged 3 commits into from Mar 19, 2019
Merged

Make the version within makefile overwriteable #6080

merged 3 commits into from Mar 19, 2019

Conversation

techknowlogick
Copy link
Member

Fix #1173

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Feb 15, 2019
@codecov-io
Copy link

codecov-io commented Feb 15, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@0b94f10). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6080   +/-   ##
=========================================
  Coverage          ?   38.86%           
=========================================
  Files             ?      365           
  Lines             ?    51341           
  Branches          ?        0           
=========================================
  Hits              ?    19953           
  Misses            ?    28516           
  Partials          ?     2872

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b94f10...a32613e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Feb 15, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 15, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 15, 2019
@techknowlogick techknowlogick merged commit d10a668 into go-gitea:master Mar 19, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-14 branch March 19, 2019 02:29
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Make the version within makefile overwriteable
5 participants
@techknowlogick @codecov-io @tboerger @zeripath @GiteaBot