Add regenerate secret feature for oauth2 #6291
Conversation
jonasfranz
added
type/enhancement
GiteaBot
added
the
lgtm/need 1
| return | ||
| } | ||
| ctx.Flash.Success(ctx.Tr("settings.update_oauth2_application_success")) | ||
| ctx.HTML(200, tplSettingsOAuthApplications) |
There was a problem hiding this comment.
I would like we redirect to the oauth2 application edit page but not render it again so that it's safe to refresh the current page.
There was a problem hiding this comment.
This won't work since the secret is not saved and will only be shown once.
There was a problem hiding this comment.
Don't familiar with macaron and I don't know if it supports what I said. I will give this a LGTM and so that my opinion will not block this.
There was a problem hiding this comment.
The only way would be via session but that would complicate the procedure a lot and it will be less secure since the token is saved in ram / session provider.
There was a problem hiding this comment.
There is temporary session variables that allow this work for redirects
Codecov Report
@@ Coverage Diff @@
## master #6291 +/- ##
==========================================
- Coverage 38.89% 38.88% -0.02%
==========================================
Files 359 359
Lines 50993 51018 +25
==========================================
+ Hits 19833 19836 +3
- Misses 28290 28312 +22
Partials 2870 2870
Continue to review full report at Codecov.
|
GiteaBot
added
lgtm/done
No description provided.