Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates SDK dep #6406

Merged
merged 5 commits into from Mar 22, 2019
Merged

Updates SDK dep #6406

merged 5 commits into from Mar 22, 2019

Conversation

richmahn
Copy link
Contributor

@richmahn richmahn commented Mar 21, 2019 •
edited

Does a dep ensure -update code.gitea.io/sdk to add new structs in the sdk

Also updates commits.go to use the Identity substruct

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 21, 2019
lafriks
lafriks requested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally breaking change... and make our API less like GitHub's

lafriks
lafriks approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, overlooked :)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2019
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Mar 21, 2019
@lafriks
Copy link
Member

lafriks commented Mar 21, 2019

I don't know why but looks like swagger json needs to be updated, see drone CI output

@richmahn
Copy link
Contributor Author

@lafriks Yeah, saw that just now. Thanks for your input. Got the swagger updated.

@codecov-io
Copy link

codecov-io commented Mar 22, 2019 •
edited

Codecov Report

Merging #6406 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6406      +/-   ##
==========================================
+ Coverage   38.85%   38.87%   +0.01%     
==========================================
  Files         365      365              
  Lines       51389    51393       +4     
==========================================
+ Hits        19968    19978      +10     
+ Misses      28553    28546       -7     
- Partials     2868     2869       +1
Impacted Files Coverage Δ
routers/api/v1/repo/commits.go 72.91% <100%> (+1.17%) ⬆️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e4db4...c3ce62b. Read the comment docs.

@techknowlogick techknowlogick merged commit ecce28f into go-gitea:master Mar 22, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@axifive axifive axifive approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@richmahn @lafriks @codecov-io @axifive @techknowlogick @GiteaBot