Pre-calculate the absolute path of git

[typeless]

Related to #6386

Avoid the overhead of searching large PATH.

[codecov-io]

Codecov Report

Merging #6575 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #6575      +/-   ##
==========================================
+ Coverage   40.76%   40.77%   +<.01%     
==========================================
  Files         407      407              
  Lines       54730    54735       +5     
==========================================
+ Hits        22310    22317       +7     
+ Misses      29366    29362       -4     
- Partials     3054     3056       +2

Impacted Files	Coverage Δ
modules/git/command.go	95.52% <100%> (ø)	⬆️
modules/git/git.go	36.73% <60%> (+2.64%)	⬆️
models/repo_list.go	66.84% <0%> (-1.06%)	⬇️
routers/repo/view.go	42.07% <0%> (+0.99%)	⬆️
models/unit.go	14.28% <0%> (+14.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4c29c...c45b3fc. Read the comment docs.

[sapk]

I found this solution quite simple for the user/admin and for others calls to git we just have to update call to "git" to GitExecutable in order to optimise them. Or we can even migrate them to NewCommand.

Some could easily be found :

• gitea/models/repo.go

  Line 124 in 704da08

  if _, err := exec.LookPath("git"); err != nil {

  (could be removed)

• gitea/models/repo.go

  Line 142 in 704da08

  if stdout, stderr, err := process.GetManager().Exec("NewRepoContext(get setting)", "git", "config", "--get", configKey); err != nil || strings.TrimSpace(stdout) == "" {

  (need update)

• gitea/modules/uploader/repo.go

  Line 131 in 296814e

  cmd := exec.CommandContext(ctx, "git", cmdArgs...)

• ...

For more : https://github.com/go-gitea/gitea/search?l=Go&q=git+Exec

[lunny]

@sapk Yes, we should move all the git commands to modules/git that's one reason of we merged git repository to gitea. And we need many refactor PRs to do that. For a git command configuration, I would like to don't change it or just change it when it is a relative path.

[zeripath]

In #6505 I'm moving a lot of the git calls to modules/git. I could complete the job easily if wanted.