Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AppURL for Oauth user link #6894

Merged
merged 3 commits into from
May 9, 2019
Merged

Use AppURL for Oauth user link #6894

merged 3 commits into from
May 9, 2019

Conversation

techknowlogick
Copy link
Member

Fix #6843

@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels May 9, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone May 9, 2019
@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #6894 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6894   +/-   ##
=======================================
  Coverage   41.41%   41.41%           
=======================================
  Files         432      432           
  Lines       59552    59552           
=======================================
  Hits        24664    24664           
- Misses      31648    31649    +1     
+ Partials     3240     3239    -1
Impacted Files Coverage Δ
routers/user/oauth.go 43.86% <100%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db3dc7...933a918. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 9, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2019
@lafriks lafriks merged commit 2f21bc3 into go-gitea:master May 9, 2019
@lafriks
Copy link
Member

lafriks commented May 9, 2019

Please backport

zeripath pushed a commit to zeripath/gitea that referenced this pull request May 11, 2019
* Use AppURL for Oauth user link

Fix go-gitea#6843

* Update oauth.go

* Update oauth.go
techknowlogick pushed a commit that referenced this pull request May 11, 2019
* Add options to git.Clone to make it more capable

* Begin the process of removing the local copy and tidy up

* Remove Wiki LocalCopy Checkouts

* Remove the last LocalRepo helpers

* Remove WithTemporaryFile

* Enable push-hooks for these routes

* Ensure tests cope with hooks

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Remove Repository.LocalCopyPath()

* Move temporary repo to use the standard temporary path

* Fix the tests

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Remove LocalWikiPath

* Fix missing remove

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Use AppURL for Oauth user link (#6894)

* Use AppURL for Oauth user link

Fix #6843

* Update oauth.go

* Update oauth.go

* internal/ssh: ignore env command totally (#6825)

* ssh: ignore env command totally

* Remove commented code 

Needed fix described in issue #6889

* Escape the commit message on issues update and title in telegram hook (#6901)

* update sdk to latest (#6903)

* improve description of branch protection (fix #6886) (#6906)

The branch protection description text were not quite accurate.

* Fix logging documentation (#6904)

* ENABLE_MACARON_REDIRECT should be REDIRECT_MACARON_LOG

* Allow DISABLE_ROUTER_LOG to be set in the [log] section

* [skip ci] Updated translations via Crowdin

* Move sdk structs to modules/structs (#6905)

* move sdk structs to moduels/structs

* fix tests

* fix fmt

* fix swagger

* fix vendor
lafriks pushed a commit that referenced this pull request May 13, 2019
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect url Oauth2
5 participants