Default to logging to stdout/stderr under systemd

[silverwind]

We get a number of issues like #6972 with no usable error information because apparently gitea does not log anything to the stdout and stderr when it encounters runtime errors. I'm not sure how these deployments are done, but I assume log.mode does not include console?

[lunny]

log.mode default will record nothing if you ignore that setting I think. @zeripath

[zeripath]

We can't detect if we're being run by systemd or not very easily - (I think if our parent is pid 0 that's probably the only way). Further people are very particular about logging so overriding them is not really acceptable.

However what we could do recommend is that the basic logging config is:

[Log]
Mode=error_console

[Log.error_console]
Mode=console
Stderr=true
Level=Error

That should at least give us something

Edit: my phone keyboard is being really annoying of late. I'm so sorry to keep closing things by mistake.

[silverwind]

Yes, no need to detect systemd, this is purely about documentation. I think we should adjust our app.ini.sample to include error logging on stderr.

What is this error_console mode? It seems undocumented.

[zeripath]

You can name a logger whatever you like, the mode will default to the name if you don't provide it.

The ability to do this was mentioned here #6095 in the Subloggers section and https://docs.gitea.io/en-us/config-cheat-sheet/#log-subsections-log-name-log-name

[silverwind]

I see. Why not just change the default for the console logger to include stderr?

[log.console]
LEVEL =
STDERR = true

[zeripath]

It's best to keep stderr for errors only. If you use [log.console] to configure that logger, then if you want to add a console logger for easy debugging then it becomes more difficult.

It doesn't really matter I guess - it's supposed to be configurable.

[silverwind]

Ah, so the console logger is bound to only log to stdout if it has STDERR=false? In that case, your suggestion makes sense. Should we then define two default loggers, console and error_console to get both streams properly attached?

Generally, I think the logger configuration, while flexible, is a bit too complex for regular users to understand.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.