Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approvals number on pull request list #7116

Closed
lunny opened this issue Jun 3, 2019 · 11 comments
Closed

Approvals number on pull request list #7116

lunny opened this issue Jun 3, 2019 · 11 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@lunny
Copy link
Member

lunny commented Jun 3, 2019

If the approvals number displayed on pull request list, that will help.

@lunny lunny added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jun 3, 2019
@stale
Copy link

stale bot commented Aug 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 2, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 2, 2019
@stale stale bot removed the issue/stale label Aug 2, 2019
@Toxik1983
Copy link

Any indication on when this feature will be implemented? Our team processes a large number of PRs a day, and we use a system of 2 needed approvals. The PRs that have already been approved by one reviewer could more easily be prioritized by the other reviewers if this number was shown in the list.

@lafriks
Copy link
Member

lafriks commented Feb 17, 2020

I think it's being worked on as should be available in 1.12

@otbutz
Copy link

otbutz commented Apr 28, 2020

#10238

@zeripath
Copy link
Contributor

@otbutz #10238 almost completes this feature but it doesn't give an idea of how many reviews are required - which is why I didn't close this bug with that pr.

@otbutz
Copy link

otbutz commented Apr 28, 2020

Ah, thanks for that insight. But nevertheless, it's progress ;)

@camlafit
Copy link
Contributor

related also to #13594 and #9274
some reverts look be done betweend these PR and actual state

@camlafit
Copy link
Contributor

This feature is asked by SPIP community as we have many PR. It'll helpful to process final review/merge with a one page to check state approval :)

@brunob
Copy link

brunob commented Jan 29, 2024

I think this one could be closed now :)

@delvh delvh closed this as completed Jan 29, 2024
@otbutz
Copy link

otbutz commented Jan 30, 2024

@otbutz #10238 almost completes this feature but it doesn't give an idea of how many reviews are required - which is why I didn't close this bug with that pr.

Is that one covered?

Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

8 participants