Fixes #2738 - Adds the /git/tags API endpoint #7138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richmahn
changed the title
richmahn
changed the title
richmahn
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7138 +/- ##
==========================================
+ Coverage 41.62% 41.76% +0.13%
==========================================
Files 448 448
Lines 60902 61061 +159
==========================================
+ Hits 25352 25502 +150
+ Misses 32262 32248 -14
- Partials 3288 3311 +23
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
richmahn
commented
Jun 6, 2019
richmahn
commented
Jun 6, 2019
richmahn
commented
Jun 6, 2019
lafriks
requested changes
Jun 6, 2019
Co-Authored-By: Lauris BH <lauris@nix.lv>
lafriks
added
the
type/feature
lafriks
approved these changes
Jun 7, 2019
GiteaBot
added
lgtm/need 1
lafriks
reviewed
Jun 7, 2019
lunny
approved these changes
Jun 8, 2019
GiteaBot
added
lgtm/done
lafriks
approved these changes
Jun 8, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* Fixes go-gitea#2738 - /git/tags API * proper URLs * Adds function comments * Updates swagger * Removes newline from tag message * Removes trailing newline from commit message * Adds integration test * Removed debugging * Adds tests * Fixes bug where multiple tags of same commit show wrong tag name * Fix formatting * Removes unused varaible * Fix to annotated tag function names and response * Update modules/git/repo_tag.go Co-Authored-By: Lauris BH <lauris@nix.lv> * Uses TagPrefix * Changes per review, better error handling for getting tag and commit IDs * Fix to getting commit ID * Fix to getting commit ID * Fix to getting commit ID * Fix to getting commit ID
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2738 (2nd part)
Read the issue above, especially the recent comment by the user (#2738 (comment)) on why I had to change a bit of stuff in how the tags API works.
Adds the {owner}/{repo}/git/tags API endpoint and properly identifies lightweight (commit) and annotated (tag) tags in the {owner}/{repo}/git/refs/tags API endpoint.
Fixes the API URLs that were not generating properly (no host name), e.g. "url:" of https://try.gitea.io/api/v1/repos/richmahn/test/tags
Fixes bug in /tags endpoint when there are multiple tags with the same commit ID (shows the same tag name over and over for each tag due to the caching, had to clone the cached struct)