Only check and config git on web subcommand but not others #7236

lunny · 2019-06-18T06:59:47Z

This will remove git config and check from serv and hooks subcommands but only for web command. Should fix #7075

codecov-io · 2019-06-19T02:17:23Z

Codecov Report

Merging #7236 into master will increase coverage by 0.02%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #7236      +/-   ##
==========================================
+ Coverage   40.97%   40.99%   +0.02%     
==========================================
  Files         462      462              
  Lines       62585    62578       -7     
==========================================
+ Hits        25646    25656      +10     
+ Misses      33578    33559      -19     
- Partials     3361     3363       +2

Impacted Files	Coverage Δ
cmd/serv.go	`0% <ø> (ø)`	⬆️
routers/init.go	`65.33% <0%> (-2.73%)`	⬇️
modules/git/git.go	`39.39% <40%> (+6.06%)`	⬆️
models/repo_list.go	`73.09% <0%> (+1.01%)`	⬆️
models/unit.go	`67.56% <0%> (+5.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71cabb...6e2dee0. Read the comment docs.

zeripath

Sorry I left these in. Yes we no longer need these as git serv and git hook no longer do anything directly.

…7236) * only check and config git on web subcommand but not others * add Init in git tests

lunny added the type/bug label Jun 18, 2019

lunny added this to the 1.9.0 milestone Jun 18, 2019

lunny force-pushed the lunny/git_config_quotepath branch from a923510 to e7c0292 Compare June 18, 2019 14:19

lunny added 2 commits June 19, 2019 09:44

only check and config git on web subcommand but not others

13e231a

add Init in git tests

681a0ed

lunny force-pushed the lunny/git_config_quotepath branch from e7c0292 to 681a0ed Compare June 19, 2019 01:44

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 19, 2019

zeripath approved these changes Jun 19, 2019

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2019

mrsdizzie approved these changes Jun 19, 2019

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2019

Merge branch 'master' into lunny/git_config_quotepath

6e2dee0

lafriks merged commit 8ec6597 into go-gitea:master Jun 19, 2019

lunny deleted the lunny/git_config_quotepath branch June 20, 2019 00:33

jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Only check and config git on web subcommand but not others (go-gitea#…

97301e5

…7236) * only check and config git on web subcommand but not others * add Init in git tests

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only check and config git on web subcommand but not others #7236

Only check and config git on web subcommand but not others #7236

lunny commented Jun 18, 2019

codecov-io commented Jun 19, 2019 •

edited

zeripath left a comment

Only check and config git on web subcommand but not others #7236

Only check and config git on web subcommand but not others #7236

Conversation

lunny commented Jun 18, 2019

codecov-io commented Jun 19, 2019 • edited

Codecov Report

zeripath left a comment

Choose a reason for hiding this comment

codecov-io commented Jun 19, 2019 •

edited