Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine SSH Key Name by Comment #812

Closed
4 of 6 tasks
ghost opened this issue Feb 1, 2017 · 9 comments · Fixed by #863
Closed
4 of 6 tasks

Determine SSH Key Name by Comment #812

ghost opened this issue Feb 1, 2017 · 9 comments · Fixed by #863
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.1.0

Comments

@ghost
Copy link

ghost commented Feb 1, 2017 •
edited by tboerger
Loading

  • Gitea version (or commit ref): gitea/gitea:latest Docker container
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

I want Gitea to determine the SSH Key Name by using it's comment.
@lunny
Copy link
Member

lunny commented Feb 2, 2017

duplicated #424, please discuss there.

@lunny lunny closed this as completed Feb 2, 2017
@lunny lunny added the issue/duplicate The issue has already been reported. label Feb 2, 2017
@ghost
Copy link
Author

ghost commented Feb 5, 2017

@lunny: No, I meant the following:

Screen Record

@appleboy
Copy link
Member

appleboy commented Feb 5, 2017

@wb9688 very clear.

@ghost
Copy link
Author

ghost commented Feb 5, 2017

@appleboy: Was that meant sarcastically? If so, you could click the GIF to see it at normal speed.

@appleboy
Copy link
Member

appleboy commented Feb 5, 2017

@wb9688 No, I understood what you want. I will implement this feature.

@lunny lunny added this to the 1.x.x milestone Feb 5, 2017
@lunny lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed issue/duplicate The issue has already been reported. labels Feb 5, 2017
@lunny
Copy link
Member

lunny commented Feb 5, 2017

@wb9688 I see.

@appleboy
Copy link
Member

appleboy commented Feb 5, 2017

@lunny Reopen this issue?

@lunny lunny reopened this Feb 5, 2017
@appleboy appleboy mentioned this issue Feb 8, 2017
Merged
@appleboy
Copy link
Member

appleboy commented Feb 8, 2017

@wb9688 I created new PR to implement this feature. Please take a look at it.

@lunny lunny closed this as completed in #863 Feb 9, 2017
@lunny lunny modified the milestones: 1.1.0, 1.x.x Feb 9, 2017
@ghost
Copy link
Author

ghost commented Feb 9, 2017 via email

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

feat: fill in ssh key title automatically. appleboy/gitea
2 participants
@appleboy @lunny