Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload in issues appears to allow custom formats but actually doesn't #8130

Open
worthy7 opened this issue Sep 9, 2019 · 2 comments
Open
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@worthy7
Copy link

worthy7 commented Sep 9, 2019

Description

image

Sorry for the Japanese here, the bottom right says "Custom files" - the default.
Basically as you can see in this list, it seems to allow the upload of "zip" files etc, but if you actually select it, you can proceed and unless you mouseover the image/file thing, you don't know that actually your file is not allowed until you press "Create issue", and see that your file isn't there.

This is what it looks like trying to upload a zip, yet if you "Create issue" your files are not there.
image

Only if you mouseover do you know it's going to fail:
image

In summary:
Problem:
Allowed filetypes are not obvious.
Proposed solution(s):

  1. Make the custom filetype selector in the upload file window accurately reflect what will be allowed to be uploaded
  2. If a disallowed file is selected and upload is pressed, just show an error in the attachment preview window instead of the actual file (so, don't upload/save the reference to the upload at all)
@techknowlogick techknowlogick added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels Sep 11, 2019
@474420502
Copy link

474420502 commented Sep 16, 2019

if create issues, then the uploadfiles is no way to delete. !!!

@techknowlogick

image

@lunny
Copy link
Member

lunny commented Sep 17, 2019

@474420502 that's another issue and we have one for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

4 participants