Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci to v1.19.1 #8414

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Oct 7, 2019

As title.

Signed-off-by: kolaente <k@knt.li>
@codecov-io
Copy link

Codecov Report

Merging #8414 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8414      +/-   ##
==========================================
- Coverage   41.79%   41.79%   -0.01%     
==========================================
  Files         497      497              
  Lines       65608    65608              
==========================================
- Hits        27423    27419       -4     
- Misses      34667    34672       +5     
+ Partials     3518     3517       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.31% <0%> (-1.01%) ⬇️
models/repo_list.go 74.14% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356e1a7...9aa5085. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 7, 2019
@guillep2k
Copy link
Member

For the interested: changelog.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 7, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 7, 2019
@techknowlogick techknowlogick merged commit 249dbbe into go-gitea:master Oct 7, 2019
@techknowlogick techknowlogick added this to the 1.10.0 milestone Oct 7, 2019
@kolaente kolaente deleted the update/golangci branch October 7, 2019 17:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants